fix(test): set cwd when running node compatibility tests #30422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tango992
force-pushed
the
fix-node-compat-test-runner
branch
2 times, most recently
from
40ab514 to
3ecdb2a
Compare
bartlomieju
reviewed
Aug 16, 2025
| import { generateTestSerialId } from "./test.ts"; | ||
| import { join } from "@std/path/join"; | ||
|
|
||
| const testSuitePath = "tests/node_compat/runner/suite"; |
There was a problem hiding this comment.
Maybe let's use import.meta.resolve() or join(import.meta.url, ...) to ensure it's actually independent where it's being run from?
bartlomieju
approved these changes
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows tests to resolve path correctly, such as this one https://github.com/nodejs/node/blob/591ba692bfe30408e6a67397e7d18bfa1b9c3561/test/parallel/test-fs-cp.mjs#L35