fix(node/fs): cp should not create subfolder when both source and target are directories #30408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get are directories
marvinhagemeister
force-pushed
the
fix-node-fs-cp
branch
from
366eb98 to
811313e
Compare
| } | ||
|
|
||
| await fs.cp(src, target, { recursive: true, force: true }); | ||
| await fs.cp(src, target, { recursive: true, force: true }); |
There was a problem hiding this comment.
FYI: We don't yet do proper handling of the options here, but these are the ones that work in Node. So this test might also be helpful once we properly parse the options argument.
There was a problem hiding this comment.
I'm currently working on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both source and target paths are a directory, we should do nothing. Previously, we would create a subdirectory in the target dir and copy into that.
Fixes #30407