fix(ext/node): avoid panic when crypto.randomInt has no arguments
#30314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tango992
reviewed
Aug 5, 2025
Comment on lines
43
to
44
| if (!NumberIsSafeInteger(min) || !NumberIsSafeInteger(max)) { | ||
| throw new TypeError("max or min is not a Safe Number"); |
There was a problem hiding this comment.
How about we follow Node.js's implementation, so that we can have the same error message:
https://github.com/nodejs/node/blob/9d2368f64329bf194c4e82b349e76fdad879d32a/lib/internal/crypto/random.js#L225-L230
You can import the error from here:
import { ERR_INVALID_ARG_TYPE } from "ext:deno_node/internal/errors.ts";There was a problem hiding this comment.
Yes, of course — thanks for the suggestion
|
Thanks @garretcarrot, this looks good. Can you please run |
|
Oops, I did for the first commit and not the last one. Would it be OK to change the other Error exceptions to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30313
Changed:
minandmaxare safe integers before proceeding with the random integer calculation, to guard against a lack of arguments or an undefined first argument to therandomIntcall.I'm not sure why non-
numbervalues were prevented from being checked withNumberIsSafeIntegeror why a genericErrorwas used instead of aTypeError— I assume there may have been reasons and so may have missed something here. But it did seem the simplest way to avoid the panic.