fix(ext/node): parse fs open options correctly #30300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tango992
commented
Aug 4, 2025
Comment on lines
+155
to
+159
| if (flags & libc::O_EXCL) == libc::O_EXCL { | ||
| options.create_new = true; | ||
| options.write = true; | ||
| flags &= !libc::O_EXCL; | ||
| } |
There was a problem hiding this comment.
Here's the current logic from Deno 2.4.3:
deno/ext/node/polyfills/_fs/_fs_common.ts
Lines 222 to 226 in 5612d2e
I intentionally omitted the read permission as the Rust stdlib only requires write permission when chained with create_new:
https://doc.rust-lang.org/src/std/sys/fs/unix.rs.html#1118-1152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30299
I decided to build the
OpenOptionson the Rust side, because it's cheaper to pass integers to the op function and we can enable the fast op call. Also the tests that I added to theconfig.tomlwere already passing before this PR.