Skip to content

fix(bundle): use non-node conditions for --platform=browser #30250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2025
Merged

fix(bundle): use non-node conditions for --platform=browser #30250

merged 4 commits into from
Jul 31, 2025

Conversation

dsherret
Copy link
Member

No description provided.

@dsherret dsherret marked this pull request as ready for review July 30, 2025 21:36
@dsherret dsherret mentioned this pull request Jul 30, 2025
Closed
marvinhagemeister
marvinhagemeister approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@dsherret dsherret merged commit 1715fc5 into denoland:main Jul 31, 2025
38 of 39 checks passed
@dsherret dsherret deleted the fix_bundle_browser_platform_conditions branch July 31, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsherret @marvinhagemeister