fix: use 'deno_signals' crate for signal handling #30204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jul 25, 2025
ry
reviewed
Jul 25, 2025
Co-authored-by: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <[email protected]>
devsnek
force-pushed
the
rework_signal_handling
branch
from
ca2242c to
3c937b3
Compare
devsnek
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #30029.
Definition of signal numbers/names were moved from
ext/ostoext/signals.All occurrences of
tokio::signalAPI were replaced with helpers fromdeno_signalshelpers. Additionally clippy lints were added to ensure
tokio::signalis not usedby accident.
Closes #30223