Skip to content

fix(ext/node): use Zlib base for brotli handles #30112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 28, 2025
Merged

fix(ext/node): use Zlib base for brotli handles #30112

merged 14 commits into from
Jul 28, 2025

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jul 15, 2025 •
edited
Loading

Fixes #28507
Closes #28836

$ ../deno/target/debug/deno run -A npm:pnpm i --save yargs
Packages: +297
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 381, reused 257, downloaded 41, added 297, done

dependencies:
+ @deno/astro-adapter 0.2.1 (0.3.1 is available)
+ astro 5.12.0
+ yargs 18.0.0

@littledivy littledivy marked this pull request as ready for review July 18, 2025 16:09
@littledivy littledivy requested a review from bartlomieju July 26, 2025 13:29
@littledivy littledivy mentioned this pull request Jul 27, 2025
Closed
8 tasks
bartlomieju
bartlomieju approved these changes Jul 27, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, let's try to fix setImmediate soon to enable more tests

ext/node/polyfills/http.ts
this.on("close", () => {
this.socket.emit("close");
// Let the final data flush before closing the socket.
this.socket.once("drain", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, is this exercised any any tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing tests in tests/unit_node/http_test.ts

@littledivy littledivy merged commit 5cfe47a into denoland:main Jul 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Work towards addressing node-compat stdio streaming bugs brotli decompress stream fails in pnpm

2 participants

@littledivy @bartlomieju