fix(install,outdated): try to avoid building graph with incorrect exports #29713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
commented
Jun 11, 2025
Comment on lines
+5
to
+6
| "jsr:@denotest/[email protected]": "0.7.0", | ||
| "jsr:@denotest/[email protected]": "0.7.1", |
There was a problem hiding this comment.
The case that broke with #29642.
We would get the exports for 0.7.0, but then when building the graph we would end up resolving 0.7 -> 0.7.1, making the exports invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29707.
Not particularly happy with this one, but the only other idea I had was to just ignore errors about non-existent exports when we build the graph for a top level install. That might end up being the best solution.
For background, when you do a top level install that includes a jsr dependency, we fetch the exports for the jsr package and then use those exports as roots in the module graph (which triggers caching those files).
To find those exports correctly, we need to know what version will end up being cached, otherwise we may end up trying to reference exports that don't exist on the actual package.
Previously, we could just look up the version in the lockfile and that worked, but it turns out that was depending on the behavior that was reverted in #29642.