Skip to content

Conversation

EdamAme-x
Copy link
Contributor

Closes #26349

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

Ignoring this error might not really help with running Wrangler in Deno. It appears they use new API from vm which is currently not available in Deno.

@EdamAme-x EdamAme-x marked this pull request as draft October 17, 2024 10:33
@EdamAme-x EdamAme-x marked this pull request as ready for review October 17, 2024 11:02
@EdamAme-x
Copy link
Contributor Author

It will take more to get wrangler fully working...
However, this PR may help with compatibility.

@brandonweeks
Copy link

node:vm does not appear to be a dependency of any of the core wrangler workflows.

Patching out --experimental-vm-modules and running wrangler deploy with Deno works.

% deno run --allow-env --allow-net --allow-read --allow-run --allow-sys --allow-write --unstable-detect-cjs ~/Code/workers-sdk/packages/wrangler/wrangler-dist/cli.js versions upload

 ⛅️ wrangler 4.11.1
-------------------

🌀 Building list of assets...
✨ Read 4 files from the assets directory /Users/bweeks/Code/web/brandonweeks.github.io/dist
🌀 Starting asset upload...
No updated asset files to upload. Proceeding with deployment...
Total Upload: 0.32 KiB / gzip: 0.23 KiB
Worker Startup Time: 0 ms
No bindings found.
Uploaded holy-pine-54cf (2.75 sec)
Worker Version ID: 30c5d5d4-9ab5-4174-9916-5507bc9b9027

To deploy this version to production traffic use the command wrangler versions deploy

Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy

Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy

Given that, some variation of this change seems prudent. Would it make sense to add a deno run flag to allow specifying additional Node.js flags to ignore?

@bartlomieju bartlomieju changed the title fix(child_process): ignore node experimental option --experimental-* fix(ext/node): ignore Node.js' --experimental-* flags when spawning child process Sep 4, 2025
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bartlomieju bartlomieju enabled auto-merge (squash) September 4, 2025 11:49
@bartlomieju bartlomieju merged commit d5eaefc into denoland:main Sep 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Wrangler, the CLI for Cloudflare Workers

4 participants