fix(lsp): import map lookup for jsr subpath auto import #25025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. | |||
| // This module is browser compatible. | |||
|
|
|||
| import { join as posixJoin } from "jsr:/@std/path@^0.220.1/posix/join"; | |||
There was a problem hiding this comment.
I didn't check but I'm pretty sure this would bypass the faulty case, where tsc is using the form without the leading slash and that fails to match any import map key.
nayeemrmn
deleted the
lsp-jsr-subpath-auto-import-completion-import-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug reported by @lucacasonato.