-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat: Print deprecation message for npm packages #24992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bartlomieju
merged 11 commits into
denoland:main
from
HasanAlrimawi:deprecated-package-test
Aug 20, 2024
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6f30634
added test for deno install deprecated package
HasanAlrimawi a62b003
fixed formatting issues
HasanAlrimawi 4e775ca
fixed another formatting issue
HasanAlrimawi dea1d78
empty commit to restart ci
HasanAlrimawi 67b16e1
init logging once
HasanAlrimawi 1c3576e
Merge branch 'main' into deprecated-package-test
HasanAlrimawi 8cad738
fix: log out warning about deprecated package being installed
HasanAlrimawi e46c150
Merge branch 'deprecated-package-test' of https://github.com/HasanAlr…
HasanAlrimawi fae8b1f
fix: log out warning about deprecated package being installed
HasanAlrimawi 3fde899
Merge branch 'main' into deprecated-package-test
HasanAlrimawi ae92264
updated test output and deprecated message on install
HasanAlrimawi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
tests/registry/npm/@denotest/deprecated-package/1.0.0/main.d.mts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export declare function setValue(val: number): void; | ||
export declare function getValue(): number; | ||
export declare const url: string; |
11 changes: 11 additions & 0 deletions
11
tests/registry/npm/@denotest/deprecated-package/1.0.0/main.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
let value = 0; | ||
|
||
export function setValue(newValue) { | ||
value = newValue; | ||
} | ||
|
||
export function getValue() { | ||
return value; | ||
} | ||
|
||
export const url = import.meta.url; |
9 changes: 9 additions & 0 deletions
9
tests/registry/npm/@denotest/deprecated-package/1.0.0/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"name": "@denotest/deprecated-package", | ||
"version": "1.0.0", | ||
"type": "module", | ||
"main": "main.mjs", | ||
"types": "main.d.mts", | ||
"deprecated": "Deprecated version" | ||
} | ||
|
25 changes: 25 additions & 0 deletions
25
tests/specs/install/install_deprecated_package/__test__.jsonc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
{ | ||
"tempDir": true, | ||
"envs": { | ||
"DENO_FUTURE": "1" | ||
}, | ||
"steps": [ | ||
{ | ||
"args": "install npm:@denotest/deprecated-package", | ||
"output": "install.out" | ||
}, | ||
{ | ||
// make sure the dep got cached | ||
"args": "run --cached-only main.js", | ||
"exitCode": 0, | ||
"output": "" | ||
}, | ||
{ | ||
"args": [ | ||
"eval", | ||
"console.log(Deno.readTextFileSync('package.json').trim())" | ||
], | ||
"output": "package.json.out" | ||
} | ||
] | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Add npm:@denotest/[email protected] | ||
Download http://localhost:4260/@denotest/deprecated-package | ||
Download http://localhost:4260/@denotest/deprecated-package/1.0.0.tgz | ||
Initialize @denotest/[email protected] | ||
Warning @denotest/[email protected] is deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
import { setValue } from "@denotest/deprecated-package"; | ||
setValue(5); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"dependencies": {} | ||
} |
3 changes: 3 additions & 0 deletions
3
tests/specs/install/install_deprecated_package/package.json.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"dependencies": { "@denotest/deprecated-package": "^1.0.0" } | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.