Skip to content

fix(upgrade): fallback to Content-Length header for progress bar #24923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix(upgrade): fallback to Content-Length header for progress bar #24923

merged 1 commit into from
Aug 7, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 7, 2024 •
edited
Loading

If the "size hint" does not provide a value, fall back to using a "Content-Length"
header.

@bartlomieju bartlomieju requested a review from dsherret August 7, 2024 08:41
dsherret
dsherret approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) August 7, 2024 09:09
@bartlomieju bartlomieju merged commit fe64cbd into denoland:main Aug 7, 2024
17 checks passed
@bartlomieju bartlomieju deleted the fix_progress_bar branch August 7, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret