Skip to content

feat: deno run <task> #24891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 6, 2024
Merged

feat: deno run <task> #24891

merged 8 commits into from
Aug 6, 2024

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Aug 5, 2024

This PR updates deno run to fallback to executing tasks when there is no script with the specified name. If there are both script and a task with the same name then deno run will prioritise executing the script.

@satyarohith satyarohith marked this pull request as ready for review August 6, 2024 07:26
@satyarohith satyarohith requested a review from crowlKats August 6, 2024 09:05
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyarohith satyarohith merged commit b3f1f3b into main Aug 6, 2024
17 checks passed
@satyarohith satyarohith deleted the add_deno_run_task branch August 6, 2024 15:05
@birkskyum
Copy link
Contributor

This PR updates deno run to fallback to executing tasks when there is no script with the specified name. If there are both script and a task with the same name then deno run will prioritise executing the script.

just to be clear, when we talk about tasks, that's the ones in the package.json scripts, and when we talk about scripts that's the deno.json right?

@bartlomieju
Copy link
Member

@birkskyum if you run deno run dev and Deno doesn't find file named dev it will try to run deno task dev which takes into account both deno.json and package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants