Skip to content

fix: update dry run success message #24885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2024
Merged

fix: update dry run success message #24885

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa9201
update dry rrun success message
HasanAlrimawi Aug 5, 2024
36a886f
update message of dry run
HasanAlrimawi Aug 6, 2024
913dcd5
Apply suggestions from code review
dsherret Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/tools/registry/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ pub async fn publish(
log::info!(" {} ({})", file.specifier, human_size(file.size as f64),);
}
}
log::warn!("{} Aborting due to --dry-run", colors::yellow("Warning"));
log::warn!("{} Dry run complete", colors::green("Success"));
return Ok(());
}

Expand Down
2 changes: 1 addition & 1 deletion tests/specs/jsr/no_unused_params/publish.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ Simulating publish of @scope/[email protected] with files:
file:///[WILDLINE]/main.out ([WILDLINE])
file:///[WILDLINE]/main.ts ([WILDLINE])
file:///[WILDLINE]/publish.out ([WILDLINE])
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/bare_node_builtins/bare_node_builtins.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ Simulating publish of @foo/[email protected] with files:
file:///[WILDLINE]/LICENSE ([WILDLINE])
file:///[WILDLINE]/deno.json (87B)
file:///[WILDLINE]/mod.ts (121B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/bare_node_builtins/no_warnings.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ Simulating publish of @foo/[email protected] with files:
file:///[WILDLINE]/LICENSE ([WILDLINE])
file:///[WILDLINE]/deno.json (87B)
file:///[WILDLINE]/mod.ts (121B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/byonm_dep/publish.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ Simulating publish of @scope/[email protected] with files:
file:///[WILDLINE]/LICENSE ([WILDLINE])
file:///[WILDLINE]/deno.jsonc ([WILDLINE])
file:///[WILDLINE]/mod.ts ([WILDLINE])
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/byonm_with_package_json/publish.out
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[WILDCARD]Unfurled specifier: @denotest/add from [WILDLINE]/src/index.ts -> npm:@denotest/add@1
[WILDCARD]
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/dry_run/dry_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ Simulating publish of @foo/[email protected] with files:
[WILDCARD]deno.json (140B)
[WILDCARD]mod.ts (137B)
[WILDCARD]std_http.ts (119B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/excluded_deno_jsonc/mod.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ Simulating publish of @scope/[email protected] with files:
file:///[WILDLINE]/LICENSE ([WILDLINE])
file:///[WILDLINE]/deno.jsonc (74B)
file:///[WILDLINE]/mod.ts (22B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/npm_workspace/publish.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ Simulating publish of @scope/[email protected] with files:
file:///[WILDLINE]/npm_workspace/subtract/jsr.json ([WILDLINE])
file:///[WILDLINE]/npm_workspace/subtract/package.json ([WILDLINE])
[UNORDERED_END]
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/sloppy_imports/sloppy_imports.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ Simulating publish of @foo/[email protected] with files:
file:///[WILDCARD]/b/index.ts (27B)
file:///[WILDCARD]/deno.json (87B)
file:///[WILDCARD]/mod.ts (35B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/sloppy_imports/sloppy_imports_no_warnings.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ Simulating publish of @foo/[email protected] with files:
file:///[WILDCARD]/b/index.ts (27B)
file:///[WILDCARD]/deno.json (87B)
file:///[WILDCARD]/mod.ts (35B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/symlink/symlink.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ warning[unsupported-file-type]: unsupported file type 'symlink'
Simulating publish of @foo/[email protected] with files:
[WILDCARD]deno.json (87B)
[WILDCARD]mod.ts (56B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/workspace/foo_dry_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ Simulating publish of @foo/[email protected] with files:
file:///[WILDLINE]/workspace/LICENSE (0B)
file:///[WILDLINE]/workspace/foo/deno.json (135B)
file:///[WILDLINE]/workspace/foo/mod.ts (118B)
Warning Aborting due to --dry-run
Success Dry run complete
2 changes: 1 addition & 1 deletion tests/specs/publish/workspace/workspace_dry_run.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ Simulating publish of @foo/[email protected] with files:
file:///[WILDLINE]/workspace/bar/deno.json (87B)
file:///[WILDLINE]/workspace/bar/mod.ts (70B)
[UNORDERED_END]
Warning Aborting due to --dry-run
Success Dry run complete
11 changes: 11 additions & 0 deletions tests/testdata/run/lock_check_ok2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,16 @@
"http://localhost:4545/subdir/mt_text_typescript.t1.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18",
"http://localhost:4545/subdir/mt_video_mp2t.t3.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18",
"http://localhost:4545/subdir/mt_video_vdn.t2.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18"
},
"workspace": {
"packageJson": {
"dependencies": [
"npm:@ngrx/store-devtools@^14.3.2",
"npm:@stripe/stripe-js@^2.1.6",
"npm:path-to-regexp@^7.0.0",
"npm:stripe@^13.8.0",
"npm:uuid@^3.4.0"
]
}
}
}
13 changes: 12 additions & 1 deletion tests/testdata/run/lock_v2_check_ok2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "2",
"version": "3",
"remote": {
"http://localhost:4545/subdir/mt_application_ecmascript.j2.js": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18",
"http://localhost:4545/subdir/mt_application_x_javascript.j4.js": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18",
Expand All @@ -9,5 +9,16 @@
"http://localhost:4545/subdir/mt_text_typescript.t1.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18",
"http://localhost:4545/subdir/mt_video_mp2t.t3.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18",
"http://localhost:4545/subdir/mt_video_vdn.t2.ts": "3a3e002e2f92dc8f045bd4a7c66b4791453ad0417b038dd2b2d9d0f277c44f18"
},
"workspace": {
"packageJson": {
"dependencies": [
"npm:@ngrx/store-devtools@^14.3.2",
"npm:@stripe/stripe-js@^2.1.6",
"npm:path-to-regexp@^7.0.0",
"npm:stripe@^13.8.0",
"npm:uuid@^3.4.0"
]
}
}
}