fix(node): support wildcards in package.json imports #24794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
dsherret
commented
Jul 30, 2024
| @@ -597,7 +597,7 @@ impl<TEnv: NodeResolverEnv> NodeResolver<TEnv> { | |||
| for key in imports.keys() { | |||
| let pattern_index = key.find('*'); | |||
| if let Some(pattern_index) = pattern_index { | |||
| let key_sub = &key[0..=pattern_index]; | |||
| let key_sub = &key[0..pattern_index]; | |||
There was a problem hiding this comment.
Slight bug copying the code from https://github.com/nodejs/node/blob/f9f9a421a8d3826ade3087a58c4c8535b8af62d0/lib/internal/modules/esm/resolve.js#L707
marvinhagemeister
approved these changes
Jul 30, 2024
crowlKats
pushed a commit
that referenced
this pull request
Jul 31, 2024
(cherry picked from commit 7a38101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24790