Skip to content

Conversation

dsherret
Copy link
Member

Part of #24676 , but just a warning for now.

@dsherret dsherret requested a review from bartlomieju July 22, 2024 16:33
@@ -507,6 +524,9 @@ impl Diagnostic for PublishDiagnostic {
"https://jsr.io/go/banned-triple-slash-directives",
)),
SyntaxError(diagnostic) => diagnostic.docs_url(),
MissingLicense { .. } => {
Some(Cow::Borrowed("https://jsr.io/go/missing-license"))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherret dsherret requested a review from lucacasonato July 22, 2024 16:35
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret merged commit 6960637 into denoland:main Jul 22, 2024
17 checks passed
@dsherret dsherret deleted the fix_publish_license_file branch July 22, 2024 19:46
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants