Skip to content

fix: WebSocketStream ping event causes pending promises #15235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2022
Merged

fix: WebSocketStream ping event causes pending promises #15235

merged 3 commits into from
Jul 18, 2022

Conversation

crowlKats
Copy link
Member

No description provided.

bartlomieju
bartlomieju approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 2eb27c9 into denoland:main Jul 18, 2022
@crowlKats crowlKats deleted the websocketstream_fix_ping_handling branch July 18, 2022 20:49
@Officialstrike Officialstrike mentioned this pull request Jul 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crowlKats @bartlomieju