Skip to content

fix(cli): Improve error message in watch mode #15184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

fix(cli): Improve error message in watch mode #15184

merged 2 commits into from
Jul 13, 2022

Conversation

yoseio
Copy link
Contributor

@yoseio yoseio commented Jul 13, 2022

fixes #15120

@bartlomieju
Copy link
Member

Thanks for the PR, it looks good. Can you update one of the watcher tests (in cli/tests/integration/watcher_tests.rs that exercises this change?

@bartlomieju bartlomieju requested a review from dsherret July 13, 2022 13:43
bartlomieju
bartlomieju approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice fix, thank you @2shiori17

@bartlomieju bartlomieju merged commit 0aca3f0 into denoland:main Jul 13, 2022
@yoseio yoseio deleted the print-error-cause branch July 13, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error cause is not printed in deno run --watch, only in deno run without --watch

2 participants

@yoseio @bartlomieju