fix(ext/ffi): i64 arg to C mapping was wrong #15162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small error slipped through in the 64 bit arguments mapping to C types for the Fast API trampoline functions. i64 and isize parameters were mapped to
uint64_t.This PR fixes the mistake, then fixes the test that was written to expect the
isizeto map intouint64_tto instead expectint64_t. Finally, I added some line breaks to the codegen'ed C output to make them more readable, hoping to avoid any future lapses like this. Now it's a bit more clear that the types wouldn't have matched originally.