Skip to content

perf(ext/web): optimize atob/btoa #13841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 5, 2022
Merged

perf(ext/web): optimize atob/btoa #13841

merged 7 commits into from
Mar 5, 2022

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Mar 4, 2022 •
edited
Loading

Follow up to #13839, optimizing base64_roundtrip ~20x (~125ms => ~6.5ms)

Before:

base64_roundtrip:    	n = 100, dt = 12.493s, r = 8/s, t = 124930000ns/op

After:

base64_roundtrip:    	n = 100, dt = 0.649s, r = 154/s, t = 6490000ns/op

lucacasonato
lucacasonato reviewed Mar 5, 2022
View reviewed changes
@AaronO AaronO merged commit 72d593f into denoland:main Mar 5, 2022
@AaronO AaronO deleted the perf/web-base64 branch March 5, 2022 19:12
kt3k pushed a commit that referenced this pull request Mar 10, 2022
@AaronO @kt3k
perf(ext/web): optimize atob/btoa (#13841)
d55acb4 
Follow up to #13839, optimizing `base64_roundtrip` ~20x (~125ms => ~6.5ms)
@Nugine Nugine mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@kt3k kt3k Awaiting requested review from kt3k

@piscisaureus piscisaureus Awaiting requested review from piscisaureus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AaronO @lucacasonato @bartlomieju