feat: remove the custom podman-darwin module #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delafthi
force-pushed
the
push-nrywpppwkuyl
branch
3 times, most recently
from
132df7f to
8c57da2
Compare
This change removes our custom podman-darwin module that manually managed Podman machines on macOS. Instead, we now rely on home-manager's native podman module which includes proper launchd integration for machine management. Waits for: nix-community/home-manager#8102
delafthi
force-pushed
the
push-nrywpppwkuyl
branch
from
8c57da2 to
3ee04de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove custom podman-darwin module in favor of home-manager's native podman service with launchd integration support.
Changes
modules/home/services/podman-darwin.nixmodule (237 lines)modules/home/services/directory structurehome/shared/dev/podman.nixto use nativeservices.podmanMotivation
Previously, we maintained a custom module to manage Podman machines on macOS with declarative configuration and automatic startup via launchd agents. This required ~240 lines of custom code to handle machine lifecycle, watchdog processes, and launchd integration.
Home-manager now provides native support for Podman machine management on Darwin (including launchd integration), making our custom implementation redundant. By migrating to the upstream implementation, we:
Dependencies
Waits for: nix-community/home-manager#8102
This PR depends on the upstream home-manager PR being merged and released, which adds proper launchd support for Podman machines on macOS.