Add update option for embeddings #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishsriv
approved these changes
Nov 8, 2024
|
The tests failed due to the sentence-transformers version conflicting with the huggingface-hub version (which is probably the latest since it isn't specified in the requirements file). The solution is to either upgrade the sentence-transformers package or downgrade the huggingface-hub package. I chose the first option and modified the requirements file. The tests run OK in my local machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read on the readme file that if the changes happen to the database then new embeddings are required. However, the user should manually go and delete the old embeddings. Therefore I thought that adding an update paramter to the load_embeddings function can make the process more automatic.