-
Notifications
You must be signed in to change notification settings - Fork 29
chore(docs): diagrams as code with likec4 #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The diagrams look better than I initially thought! :) Could we update the colors (especially that red-ish one) to match the UDS Registry branding? |
fix: ci task reference fix: ci diagram check fix: ci update diagrams
c1eee6c to
47aa132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment and wanted to suggest adding a short ADR with a compiled version of arguments why we switched to C4. Otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking awesome!
Haven't done an in depth review yet but a couple comments/questions at a first pass:
- If the image files are changing frequently, do you think it is worth starting to store these images in git lfs? (might save us some pain down the line as the git history of uds-core grows)
- I think we can get rid of the namespace views based on another comment (not providing too much value IMO)
- I think it is fine for the functional layer views to only contain the components delivered in that layer
Other than that, I think this is looking pretty solid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally lgtm! Add a few comments for consideration
Description
We recently decided to use diagrams as code for creating and maintaining our diagrams. This should reduce maintenance burden and speed up creation of new diagrams.
Because this is diagrams as code, we lose some ability to customize how the diagram is generated. There is the ability with likec4 to manually edit and arrange diagrams, however doing this has some big pitfalls:
Currently created diagrams:
Open Questions
Related Issue
Fixes #1955
Type of change
Checklist before merging