add timers and performance metrics #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awan-10
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
conglongli,
duli2012,
eltonzheng,
jeffra,
minjiaz,
mrwyattii,
samyam,
tjruwase,
xiaoxiawu-microsoft and
yaozhewei
as code owners
lekurile
approved these changes
Aug 18, 2023
Contributor
lekurile
left a comment
lekurile
left a comment
There was a problem hiding this comment.
LGTM, left a few comments about how to potentially clean up a few items. Thanks!
applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/main.py
Outdated
Show resolved
Hide resolved
applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/ppo_trainer.py
Outdated
Show resolved
Hide resolved
yaozhewei
reviewed
Aug 18, 2023
yaozhewei
reviewed
Aug 18, 2023
applications/DeepSpeed-Chat/training/step3_rlhf_finetuning/main.py
Outdated
Show resolved
Hide resolved
yaozhewei
reviewed
Aug 18, 2023
yaozhewei
reviewed
Aug 18, 2023
* update flops calculation * fix and verify flops. add for step 1 as well. --------- Co-authored-by: Ammar Ahmad Awan <[email protected]>
LeetJoe
pushed a commit
to LeetJoe/DeepSpeedExamples
that referenced
this pull request
Sep 15, 2023
Co-authored-by: Ammar Ahmad Awan <[email protected]> Co-authored-by: Molly Smith <[email protected]> Co-authored-by: Lev Kurilenko <[email protected]> Co-authored-by: Zhewei Yao <[email protected]>
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
Co-authored-by: Ammar Ahmad Awan <[email protected]> Co-authored-by: Molly Smith <[email protected]> Co-authored-by: Lev Kurilenko <[email protected]> Co-authored-by: Zhewei Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timers and logging functions to properly calculate latencies, FLOPs, and achieved bandwidth for various phases of the RLHF training step.