-
Notifications
You must be signed in to change notification settings - Fork 1.1k
10-20x faster load checkpoint (for critic/reward model) #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaozhewei
approved these changes
Aug 8, 2023
Contributor
yaozhewei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing debugging and change step ==1 back, the rest looks great to me
lekurile
approved these changes
Aug 9, 2023
Contributor
lekurile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…Examples into amawa/fast-load-ckpt
…eepSpeedExamples into amawa/fast-load-ckpt
LeetJoe
pushed a commit
to LeetJoe/DeepSpeedExamples
that referenced
this pull request
Sep 15, 2023
) Co-authored-by: Lev Kurilenko <[email protected]>
hwchen2017
pushed a commit
that referenced
this pull request
Jun 8, 2025
Co-authored-by: Lev Kurilenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new code path to provide 10-20x faster load checkpoint times. The code has been adapted from HF from_pretrained functionality when DeepSpeed Z3 is enabled.