-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Add AzureOpenAIResponsesChatGenerator
#10019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
149c315 to
94508be
Compare
mpangrazzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already good! Left some minor comments.
Also, I think it would be nice to have a live run integration test with reasoning model (like gpt-5-nano), WDYT?
releasenotes/notes/add-azure-responses-api-1b2c990a060b09f5.yaml
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 19134929429Details
💛 - Coveralls |
@mpangrazzi I was able to test with |
|
@sjrl sounds good! |
|
@mpangrazzi feel free to approve ;) |
Related Issues
AzureOpenAIResponsesChatGeneratorbased on theOpenAIResponsesChatGenerator#9986Proposed Changes:
AzureOpenAIResponsesChatGeneratorwhich inherits fromOpenAIResponsesChatGeneratorto use Azure OpenAI's Responses APIHow did you test it?
Notes for the reviewer
super().__init__()in the component. It still makes sense to make a dedicated component since specifying thebase_urlis a little clunky and it's easier to keep the old parameterazure_deploymentwhich is then used to create thebase_url.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.