Skip to content

[cherry-pick] add ignore_eos support in chat completions schema (#2281) #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2024
Merged

[cherry-pick] add ignore_eos support in chat completions schema (#2281) #2283

merged 1 commit into from
Aug 6, 2024

Conversation

@siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Aug 6, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@siddvenk siddvenk requested review from a team, frankfliu and zachgk as code owners August 6, 2024 02:26
@lanking520 lanking520 merged commit b46b23a into deepjavalibrary:0.29.0-dlc Aug 6, 2024
@siddvenk siddvenk deleted the 0.29.0-dlc branch August 6, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

1 more reviewer

@lanking520 lanking520 lanking520 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddvenk @lanking520