Skip to content

Conversation

@siddvenk
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@siddvenk siddvenk requested review from a team, frankfliu and zachgk as code owners July 25, 2024 20:45
@lanking520
Copy link
Contributor

should we just close or migrate this one? #2157

"option.model_id": "s3://djl-llm/llava-v1.6-mistral-7b-hf",
},
"paligemma-3b-mix-448": {
"option.model_id": "s3://djl-llm/phi-3-vision-128k-instruct"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url here is not right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@siddvenk
Copy link
Contributor Author

should we just close or migrate this one? #2157

I think we can close that one - we don't need a lot of the configs that are there, and while the openai client is useful - I'd rather take that up separately and have a full Test suite for chat completions use-case/integ tests

@lanking520 lanking520 merged commit 1016a23 into deepjavalibrary:master Jul 26, 2024
@siddvenk siddvenk deleted the multimodal-tests branch August 5, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants