[tnx] fix optimum token selection and sampling #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosterberg
force-pushed
the
2_19_1-neuron
branch
from
0826974 to
86ad4f3
Compare
frankfliu
approved these changes
Jul 25, 2024
lanking520
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix transformers issue with optimum token selection post 4.43 update. Fix sampling for rolling batch post transformers bump.
OptimumTokenSelector is a copy of optimum-neuron's token selector but upgraded to work with transfomers 4.43, and can be removed and reverted after the dependencies are updated to support llama3.1