Skip to content

[wlm] Trim whitespce for model_id #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[wlm] Trim whitespce for model_id #2175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions wlm/src/main/java/ai/djl/serving/wlm/ModelInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ private String inferEngine() throws ModelException {

String modelId = prop.getProperty("option.model_id");
if (modelId != null && modelId.startsWith("djl://")) {
Repository repo = Repository.newInstance("tmp", modelId);
Repository repo = Repository.newInstance("tmp", modelId.trim());
MRL mrl = repo.getResources().get(0);
String groupId = mrl.getGroupId();
ModelZoo zoo = ModelZoo.getModelZoo(groupId);
Expand Down Expand Up @@ -1112,10 +1112,10 @@ void downloadS3() throws ModelException, IOException {
return;
}
if (modelId.startsWith("s3://")) {
this.downloadDir = downloadS3ToDownloadDir(modelId);
this.downloadDir = downloadS3ToDownloadDir(modelId.trim());
} else if (modelId.startsWith("djl://")) {
logger.info("{}: djl model zoo url found: {}", uid, modelId);
modelUrl = modelId;
modelUrl = modelId.trim();
// download real model from model zoo
downloadModel();
}
Expand Down