Skip to content

[python] add max_logprobs vllm configuration to EngineArgs #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[python] add max_logprobs vllm configuration to EngineArgs #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions engines/python/setup/djl_python/properties_manager/lmi_dist_rb_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ class LmiDistRbProperties(Properties):
max_lora_rank: Optional[int] = 16
lora_extra_vocab_size: Optional[int] = 256
max_cpu_loras: Optional[int] = None
max_logprobs: Optional[int] = 5

@model_validator(mode='after')
def validate_mpi(self):
Expand Down
1 change: 1 addition & 0 deletions engines/python/setup/djl_python/properties_manager/vllm_rb_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class VllmRbProperties(Properties):
# Neuron vLLM properties
device: Optional[str] = None
preloaded_model: Optional[Any] = None
max_logprobs: Optional[int] = 5

@field_validator('engine')
def validate_engine(cls, engine):
Expand Down
3 changes: 2 additions & 1 deletion engines/python/setup/djl_python/rolling_batch/rolling_batch_vllm_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,4 +224,5 @@ def get_engine_args_from_config(config: VllmRbProperties) -> EngineArgs:
max_lora_rank=config.max_lora_rank,
lora_extra_vocab_size=config.lora_extra_vocab_size,
max_cpu_loras=config.max_cpu_loras,
revision=config.revision)
revision=config.revision,
max_logprobs=config.max_logprobs)