Skip to content

[ci] remove HF_MODEL_ID env for lmi_dist_1 test #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2024
Merged

[ci] remove HF_MODEL_ID env for lmi_dist_1 test #2131

merged 1 commit into from
Jun 28, 2024

Conversation

@sindhuvahinis
Copy link
Contributor

Description

  • prepare.py has serving.properties, which has option.model_id=gpt2
  • and env has HF_MODEL_ID also has gpt2. So it is loading the model again, which leads to OOM.

https://github.com/deepjavalibrary/djl-serving/actions/runs/9698967044/job/26767133000#step:7:476

@sindhuvahinis sindhuvahinis requested review from a team, frankfliu and zachgk as code owners June 28, 2024 21:31
@sindhuvahinis sindhuvahinis merged commit 4fc9eb5 into deepjavalibrary:master Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

2 more reviewers

@maaquib maaquib maaquib approved these changes

@frankfliu frankfliu frankfliu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sindhuvahinis @maaquib @frankfliu