[secure-mode] Refactor secure mode plugin #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethnzhng
reviewed
Jun 13, 2024
| */ | ||
| private static void scanForPickle(Path directory) throws IOException, ModelException { | ||
| Pattern pattern = Pattern.compile(PICKLE_EXTENSIONS_REGEX); | ||
| Set<String> controls = new HashSet<>(Arrays.asList(securityControls.split("\\s+,\\s*"))); |
There was a problem hiding this comment.
I don't understand this regex, doesn't this require a whitespace before the comma? Ideally we just split around commas and then trim whitespace from each member
There was a problem hiding this comment.
Good catch, fixed.
1. Add jacoco report 2. improve code coverage 3. Remove unrelated features
sindhuvahinis
approved these changes
Jun 13, 2024
frankfliu
added a commit
to frankfliu/djl-serving
that referenced
this pull request
Jun 13, 2024
frankfliu
added a commit
to frankfliu/djl-serving
that referenced
this pull request
Jun 13, 2024
frankfliu
added a commit
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about