Skip to content

Conversation

@sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@sindhuvahinis sindhuvahinis requested review from a team, frankfliu and zachgk as code owners June 6, 2024 22:03
]
```

When using streaming: Response will be Server Sent Events (text/event-stream) which will prefix with `data:`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the error case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a separate heading 2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand, but the below sample is a demo of error condition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, Changed it

@sindhuvahinis sindhuvahinis merged commit 024780e into deepjavalibrary:master Jun 7, 2024
sindhuvahinis added a commit to sindhuvahinis/djl-serving that referenced this pull request Jun 12, 2024
@sindhuvahinis sindhuvahinis deleted the tgi branch June 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants