Skip to content

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Oct 10, 2025

  • Over time, many keys have been added to the default blacklist to account for log exporting issues on the Enterprise side. Those specific keys have been removed as the enterprise code should supply its own list for them.
  • All references to "blacklist" have been replaced with "ignore list", per a suggestion from @cpwright

@ericlln ericlln self-assigned this Oct 10, 2025
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.17%. Comparing base (c0084cf) to head (c6aa6b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
+ Coverage   44.12%   44.17%   +0.05%     
==========================================
  Files         763      763              
  Lines       42906    42906              
  Branches    10827    10827              
==========================================
+ Hits        18932    18954      +22     
+ Misses      23959    23937      -22     
  Partials       15       15              
Flag Coverage Δ
unit 44.17% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericlln
Copy link
Contributor Author

ericlln commented Oct 14, 2025

Also added a simple test for exportLogs() due to the previously failing code coverage report. It isn't tested anywhere other than indirectly in shortcuts.spec.ts where we test that pressing a shortcut causes logs to be exported.

@ericlln ericlln requested review from a team and dgodinez-dh and removed request for a team October 14, 2025 20:42
@ericlln ericlln marked this pull request as ready for review October 14, 2025 20:42
@ericlln ericlln merged commit 94a2e44 into deephaven:main Oct 15, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants