Skip to content

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Oct 9, 2025

  • I believe the functionality stopped working after 9f87985, where an added setState call at the end of componentDidUpdate would overwrite any scroll position state state changes made in checkStickyScroll()
  • Now the relevant scroll position state changes are made in the same setState call at the end of componentDidUpdate
  • Added an e2e test to test the stuck to bottom scrolling functionality

@ericlln ericlln self-assigned this Oct 9, 2025
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.14%. Comparing base (c0084cf) to head (c116f11).

Files with missing lines Patch % Lines
packages/grid/src/Grid.tsx 57.57% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2547      +/-   ##
==========================================
+ Coverage   44.12%   44.14%   +0.01%     
==========================================
  Files         763      763              
  Lines       42906    42908       +2     
  Branches    10827    10826       -1     
==========================================
+ Hits        18932    18941       +9     
+ Misses      23959    23952       -7     
  Partials       15       15              
Flag Coverage Δ
unit 44.14% <57.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericlln ericlln requested review from a team and dgodinez-dh and removed request for a team October 9, 2025 15:30
@ericlln ericlln marked this pull request as ready for review October 9, 2025 15:30
@ericlln ericlln requested a review from vbabich October 9, 2025 16:06
@ericlln
Copy link
Contributor Author

ericlln commented Oct 9, 2025

The test failure was from a test from the same file but unrelated. It failed due to a console error expansion button being present which caused a strict mode violation. I actually wasn't aware that page.getByRole() wasn't exact on name by default.

@ericlln ericlln merged commit 5216008 into deephaven:main Oct 15, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants