-
Notifications
You must be signed in to change notification settings - Fork 95
fix: correct the language property location and type #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Pylint (3.3.7)deepgram/clients/agent/v1/websocket/options.py📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
deepgram/clients/agent/v1/websocket/options.py
(3 hunks)examples/agent/async_simple/main.py
(1 hunks)examples/agent/no_mic/main.py
(1 hunks)examples/agent/simple/main.py
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/agent/async_simple/main.py
- examples/agent/no_mic/main.py
🚧 Files skipped from review as they are similar to previous changes (1)
- deepgram/clients/agent/v1/websocket/options.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I'm pretty sure I screwed this up a lot, actually.
Language should be a string field, not an object with a type property.
@naomi-lgbt alrighty I think this should do it: The Language class has been successfully removed. The Agent class still has its language field defined as a simple string. |
Proposed changes
Relates to the bug reported in The community
Let me analyze what I found:
The Language class is defined in options.py but it's not being used in any of the main client classes or settings. It appears to be defined but not integrated into the actual SDK functionality.
Looking at the SettingsOptions class which is the main configuration class used when starting a websocket connection, it doesn't include the Language class as a field.
Types of changes
Summary by CodeRabbit
Summary by CodeRabbit