Skip to content

[BE1] Address issues mentioned in the comments for pull request #1815 #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2024
Merged

[BE1] Address issues mentioned in the comments for pull request #1815 #1976

merged 2 commits into from
Jun 30, 2024

Conversation

emonnin-epfl
Copy link
Contributor

No description provided.

@emonnin-epfl emonnin-epfl requested a review from a team as a code owner June 30, 2024 19:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
57.1% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@sgueissa sgueissa enabled auto-merge June 30, 2024 20:08
sgueissa
sgueissa approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sgueissa sgueissa added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 7049cfb Jun 30, 2024
@sgueissa sgueissa deleted the work-be1-etienne-comments-previous-pr branch June 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnauds5 arnauds5 arnauds5 approved these changes

@sgueissa sgueissa sgueissa approved these changes

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees
No one assigned
Labels
be1-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emonnin-epfl @arnauds5 @sgueissa @K1li4nL