Skip to content

[BE1] Federation Data Exchange #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 27, 2024
Merged

[BE1] Federation Data Exchange #1946

merged 17 commits into from
Jun 27, 2024

Conversation

arnauds5
Copy link
Collaborator

@arnauds5 arnauds5 commented Jun 25, 2024 •
edited
Loading

  • Add federation tokens exchange handler
  • Avoid duplicate websocket connections in federation of multiple LAOs within one server
  • Add the server socket to the list of server sockets and use NewServerSocket instead of NewClientSocket
  • Fix missing federation result message if the same server is used
  • handle challenge msg of a federation init directly instead of using a websocket if only one server

@arnauds5 arnauds5 self-assigned this Jun 25, 2024
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 19
▀▀▀▀▀		 1d 20h 18m
▀		 14
▀▀▀
arnauds5
🥈		 5
▀		 18h 5m
 4
▀
emonnin-epfl
🥉		 4
▀		 8h 20m
 8
▀▀
onsriahi14
 3
▀		 1d 10h 51m
 4
▀
MariemBaccari
 2
▀		 22h 39m
 6
▀
simone-kalbermatter
 2
▀		 5h 32m
 0
matteosz
 2
▀		 1d 5h 29m
 3
▀
1florentin
 1
 19d 1h 53m
▀▀▀▀▀		 0
sgueissa
 1
 49m
 3
▀
quadcopterman
 1
 10d 7h 3m
▀▀▀		 0
⚡️ Pull request stats

@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Merged
@github-actions GitHub Actions
Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1947 first.

@arnauds5
Merge pull request #1947 from dedis/auto-format-patches/work-be1-arna…
88927cc 
…uds5-federation-data-exchange

Fixes by auto-format action
@arnauds5 arnauds5 requested a review from 1florentin June 26, 2024 09:55
@arnauds5 arnauds5 marked this pull request as ready for review June 26, 2024 09:55
@arnauds5 arnauds5 requested a review from a team as a code owner June 26, 2024 09:55
sgueissa
sgueissa requested changes Jun 26, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sgueissa
Copy link
Collaborator

LGTM

@sgueissa sgueissa enabled auto-merge June 27, 2024 05:49
1florentin
1florentin approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@1florentin 1florentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

K1li4nL
K1li4nL approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

@sgueissa sgueissa added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit 4ed41a1 Jun 27, 2024
@sgueissa sgueissa deleted the work-be1-arnauds5-federation-data-exchange branch June 27, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1florentin 1florentin 1florentin approved these changes

@sgueissa sgueissa sgueissa approved these changes

@K1li4nL K1li4nL K1li4nL approved these changes

Assignees

@arnauds5 arnauds5

Labels
be1-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnauds5 @sgueissa @1florentin @K1li4nL