Skip to content

Conversation

DanielTavaresA
Copy link
Collaborator

@DanielTavaresA DanielTavaresA commented May 25, 2024

Pending on #1877 .

Handles parsing from jsonRpc to usable object for new message RumorState

Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
7
5d 1h 1m
23
▀▀
pierluca
🥈
5
6d 22h 1m
8
onsriahi14
🥉
5
3d 1h 48m
10
matteosz
5
4d 40m
20
arnauds5
4
7d 5h 54m
12
simone-kalbermatter
4
1d 14h 46m
0
quadcopterman
4
5d 19h 9m
1
Tyratox
3
14d 6h 12m
26
▀▀
1florentin
2
8d 13h 48m
6
t1b00
2
6d 6h 52m
4
osm-alt
2
6d 22h 53m
12
ljankoschek
2
18m
0
DanielTavaresA
2
2d 10h 22m
8
Kaz-ookid
2
7d 15h 16m
7
4xiom5
1
12d 4h 52m
0
sgueissa
1
2d 23h 56m
1
MariemBaccari
1
1d 16h 52m
0
emonnin-epfl
1
51m
1
⚡️ Pull request stats

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DanielTavaresA DanielTavaresA marked this pull request as ready for review May 26, 2024 11:22
@DanielTavaresA DanielTavaresA requested a review from a team as a code owner May 26, 2024 11:22
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@K1li4nL K1li4nL added this pull request to the merge queue May 26, 2024
Merged via the queue into master with commit c71d2ad May 26, 2024
@K1li4nL K1li4nL deleted the work-be2-daniel-pull-rumor-json branch May 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants