Skip to content

Conversation

sgueissa
Copy link
Collaborator

No description provided.

@sgueissa sgueissa marked this pull request as ready for review May 29, 2024 17:50
@sgueissa sgueissa requested a review from a team as a code owner May 29, 2024 17:50
emonnin-epfl and others added 11 commits May 29, 2024 20:21
# Conflicts:
#	be1-go/cli/pop_test.go
#	be1-go/internal/popserver/database/repository/mock_repository.go
#	be1-go/internal/popserver/database/repository/repository.go
#	be1-go/internal/popserver/database/sqlite/sqlite.go
#	be1-go/internal/popserver/database/sqlite/sqlite_const.go
#	be1-go/internal/popserver/hub.go
#	be1-go/internal/popserver/state/state.go
Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@arnauds5 arnauds5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind approval

@K1li4nL K1li4nL added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit aa04c3a May 30, 2024
@sgueissa sgueissa deleted the work-be1-etienne-stuart-push-rumor branch May 30, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants