Skip to content

Conversation

arnauds5
Copy link
Collaborator

@arnauds5 arnauds5 commented Apr 10, 2024

more information here #1800

Add the following messages data:

  • federation_challenge_request
  • federation_challenge: (value is a 32 bytes array encoded in hexadecimal, valid_until is the unix timestamp of expiration)
  • federation_expect
  • federation_init (may need to modify the challenge field to a signed message containing a challenge)

documentation and new schemas need to be added

@arnauds5 arnauds5 added discussion Discussion topic proto-spec Everything related to the PoP protocol labels Apr 10, 2024
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
MariemBaccari
🥇
3
▀▀
17d 2h 53m
▀▀
2
matteosz
🥈
3
▀▀
1d 22h 20m
6
▀▀
sgueissa
🥉
2
17d 21h 43m
▀▀
4
Tyratox
1
3d 10h 1m
3
1florentin
1
6d 20h 7m
0
ljankoschek
1
7h 42m
0
simone-kalbermatter
1
16d 1h 26m
▀▀
9
▀▀▀
K1li4nL
1
18d 11h 10m
▀▀
3
Kaz-ookid
1
2d 5h 33m
1
⚡️ Pull request stats

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@arnauds5 arnauds5 changed the base branch from master to work-federation-protocol April 12, 2024 23:09
@onsriahi14
Copy link
Contributor

Since we added the necessary messages for the authentication protocol, we can already merge them into work-federation-protocol.

@onsriahi14 onsriahi14 self-requested a review April 13, 2024 11:47
@onsriahi14 onsriahi14 changed the title draft protocol federation draft authentication protocol federation Apr 13, 2024
onsriahi14
onsriahi14 approved these changes Apr 13, 2024
@onsriahi14 onsriahi14 self-requested a review April 13, 2024 12:04
@onsriahi14 onsriahi14 marked this pull request as ready for review April 13, 2024 12:05
@onsriahi14 onsriahi14 requested a review from a team as a code owner April 13, 2024 12:05
@arnauds5 arnauds5 merged commit 4d59c3c into work-federation-protocol Apr 13, 2024
@arnauds5 arnauds5 deleted the work-federations-arnauds5-add-authentication-protocol branch April 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion topic proto-spec Everything related to the PoP protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants