Skip to content

Adding unit test for hash (including with emojis) #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

Adding unit test for hash (including with emojis) #1457

merged 2 commits into from
Mar 22, 2023

Conversation

Nazianzenov
Copy link
Contributor

Just confirming the hash function is the same on Golang than on the other systems.

@Nazianzenov Nazianzenov requested a review from a team as a code owner March 15, 2023 11:56
@Nazianzenov Nazianzenov self-assigned this Mar 15, 2023
MariemBaccari
MariemBaccari previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! It's coherent with the scala PR #1440.

MaelyssGilliard
MaelyssGilliard previously approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@MaelyssGilliard MaelyssGilliard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbsv
jbsv previously approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe add a comment on how you generated the hashes in the test

@Nazianzenov
Copy link
Contributor Author

I added comments and did another commit

@sonarqubecloud
Copy link

[PoP - Be1-Go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[PoP - Be2-Scala] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[PoP - Fe2-Android] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[PoP - Fe1-Web] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Nazianzenov Nazianzenov requested a review from jbsv March 21, 2023 14:24
@Nazianzenov Nazianzenov merged commit 0b51c8b into master Mar 22, 2023
@Nazianzenov Nazianzenov deleted the work-be1-nazianze-fixing-emoji branch March 22, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsv jbsv jbsv approved these changes

@MariemBaccari MariemBaccari MariemBaccari left review comments

+1 more reviewer

@MaelyssGilliard MaelyssGilliard MaelyssGilliard left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Nazianzenov Nazianzenov

Labels
be1-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nazianzenov @MariemBaccari @MaelyssGilliard @jbsv