-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add ZStd Support #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add ZStd Support #91
Conversation
Hi! Looks interesting, but I am wondering if there really is any need for There's already I would prefer that users of DotTiled would use one of the supported alternative compression algorithms instead. With that being said, there are test cases in this PR which are very useful - all of which should be added!
If you want to amend your PR to align with this comment, I'd be more than happy to merge it, but unfortunately Also, have a look at the new contribution guidelines! Rebase the branch on |
63e4c9a
to
2a81367
Compare
While I agree If you take a look at the project GitHub the only time it uses prebuilt binaries is for benchmarking and testing purposes. |
Also, went and rebased it for now. If you still aren't interested in ZStd support let me know, I can close out this PR and put in a new one for a different branch that just has the testing for everything else. |
I hear you, let's leave this PR up for now as I make sure to get myself more acquainted with Much appreciated :) |
2a81367
to
a882e1e
Compare
Created #96 for Base64, GZip, and ZLib testing then removed them from this PR. Once that gets pulled in I will probably have to rebase this |
a882e1e
to
9c44623
Compare
This is a duplicated of #81 but targeting the dev branch, also includes testing for base64 and the various compression algorithms.