-
Notifications
You must be signed in to change notification settings - Fork 38
Add release script and GHA #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// Verify no new executions occurred | ||
finalCount := executionCount.Load() | ||
assert.Equal(t, countAfterDeactivate, finalCount, | ||
assert.LessOrEqual(t, finalCount, countAfterDeactivate+1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give some leeway to this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an automated release management system with both a Go script and GitHub Actions workflow to standardize the release process.
- Adds a release automation script that handles version bumping, tag creation, and branch management
- Creates a GitHub Actions workflow with mandatory confirmation gating for release creation
- Updates security scanning to focus on the
dbos/
directory and fixes a test assertion
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
make_release.go |
New release automation script that handles semver version bumping, tag/branch creation, and GitHub releases |
.github/workflows/new-release.yml |
GitHub Actions workflow for automated releases with manual confirmation |
.github/workflows/security.yml |
Scopes security scans to dbos/ directory only |
dbos/admin_server_test.go |
Changes test assertion from exact equality to less-than-or-equal comparison |
Comments suppressed due to low confidence (1)
make_release.go:200
- The Tagger signature is missing an Email field, which may cause issues when creating tags. Consider adding a valid email address.
},
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any notion of preview releases in Go?
No, releases, and specifically "latest", are based on (semver) tags. semver supports You can also In our tests we do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable--the same as our Python versioning script as far as I can tell.
One difference is that we reset the patch version when bumping a minor version -- I don't think the python version does that? |
Also for pre-releases, I think the convention in semver is v1.3.0-rc.1 |
I tested manually the "clean and up to date local main" requirement, the YES!!! gating, minor version bumps (including from a valid semver
-alpha
, major version bumps)