Add a few missing endpoints to admin server #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
commented
Aug 15, 2025
There was a problem hiding this comment.
The only tests I added are around list workflows:
- Check the timestamp validation (we expect UTC timestamps in the request that are converted to
time.Time) - Check that empty bodies are equated to no filters
kraftp
reviewed
Aug 18, 2025
dbos/admin_server.go
Outdated
| _WORKFLOW_STEPS_PATTERN = "GET /workflows/{id}/steps" | ||
| _WORKFLOW_CANCEL_PATTERN = "POST /workflows/{id}/cancel" | ||
| _WORKFLOW_RESUME_PATTERN = "POST /workflows/{id}/resume" | ||
| _WORKFLOW_RESTART_PATTERN = "POST /workflows/{id}/restart" |
There was a problem hiding this comment.
No restart endpoint, it's now deprecated everywhere
kraftp
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing:
Not sure we want the restart endpoint but I added it for backward compatibility