Skip to content

Conversation

vr-varad
Copy link
Contributor

Fixes #122

@vr-varad
Copy link
Contributor Author

@maxdml I added the helper function for masking in a new file named utils.go inside dbos folder.
Should I move it to system_database.go?

@vr-varad
Copy link
Contributor Author

I am not sure why the tests are failing, but I guess is it due to the printing? Do I need to use logger?

@maxdml
Copy link
Collaborator

maxdml commented Sep 17, 2025

@maxdml I added the helper function for masking in a new file named utils.go inside dbos folder. Should I move it to system_database.go?

Yes you can simply place it at the end of system_database.go, (there is a "utils" section)

Thank you!

@vr-varad vr-varad requested a review from maxdml September 18, 2025 12:58
@vr-varad
Copy link
Contributor Author

@maxdml Made the required changes. Kindly review at your convenience.

Copy link
Collaborator

@maxdml maxdml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vr-varad

@maxdml maxdml merged commit 5975528 into dbos-inc:main Sep 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display masked database URL during system DB construction

2 participants