-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: update eslint and configs #4781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/refactor-update-eslint-and-configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses version inconsistencies in ESLint configuration by updating ESLint versions across the project and removing an obsolete Dependabot configuration that was preventing major ESLint updates.
- Updated ESLint from different versions (8.57.1 and 9.29.0) to a consistent 9.33.0 across all packages
- Updated ESLint configuration packages to compatible versions
- Removed Dependabot ignore rule for ESLint major version updates
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
showcases/patternhub/package.json | Updated ESLint from 8.57.1 to 9.33.0 and eslint-config-next to 15.5.0 |
package.json | Updated ESLint from 9.29.0 to 9.33.0 and eslint-config-xo to 0.49.0 |
.github/dependabot.yml | Removed obsolete ESLint major version update ignore rule |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Proposed changes
#4780 fails because of inconsistent eslint versions. Additionally removed an obsolete dependabot config that prevented major
eslint
update PRs, which got introduced with commit 2700279, but as we even already haveeslint
updated inpackage.json
this should be obsolete, but prevented the update inshowcases/patternhub/package.json
.Types of changes
Further comments