Skip to content

Conversation

mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Aug 20, 2025

Proposed changes

#4780 fails because of inconsistent eslint versions. Additionally removed an obsolete dependabot config that prevented major eslint update PRs, which got introduced with commit 2700279, but as we even already have eslint updated in package.json this should be obsolete, but prevented the update in showcases/patternhub/package.json.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Aug 20, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Aug 20, 2025
@mfranzke mfranzke added the dependencies Pull requests that update a dependency file label Aug 20, 2025
@mfranzke mfranzke removed their assignment Aug 20, 2025
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Aug 20, 2025
@mfranzke mfranzke enabled auto-merge (squash) August 20, 2025 05:47
Copy link
Contributor

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Aug 20, 2025
@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Aug 20, 2025
@mfranzke mfranzke requested a review from Copilot August 21, 2025 16:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses version inconsistencies in ESLint configuration by updating ESLint versions across the project and removing an obsolete Dependabot configuration that was preventing major ESLint updates.

  • Updated ESLint from different versions (8.57.1 and 9.29.0) to a consistent 9.33.0 across all packages
  • Updated ESLint configuration packages to compatible versions
  • Removed Dependabot ignore rule for ESLint major version updates

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
showcases/patternhub/package.json Updated ESLint from 8.57.1 to 9.33.0 and eslint-config-next to 15.5.0
package.json Updated ESLint from 9.29.0 to 9.33.0 and eslint-config-xo to 0.49.0
.github/dependabot.yml Removed obsolete ESLint major version update ignore rule

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

michaelmkraus
michaelmkraus previously approved these changes Aug 26, 2025
Copy link

changeset-bot bot commented Aug 26, 2025

⚠️ No Changeset found

Latest commit: 079ccea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

michaelmkraus
michaelmkraus previously approved these changes Aug 26, 2025
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Aug 27, 2025
mfranzke and others added 4 commits August 27, 2025 18:06
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke merged commit c48cdcc into main Aug 28, 2025
54 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Aug 28, 2025
@mfranzke mfranzke deleted the refactor-update-eslint-and-configs branch August 28, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚢📀cicd Changes inside .github folder dependencies Pull requests that update a dependency file 📕documentation Improvements or additions to documentation 🍄🆙improvement New feature or request 📺showcases Changes to 1-n showcases
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants