fix: asyncIterator typescript return type #255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmehta
force-pushed
the
fix-async-iterator-ts-return-type
branch
from
0e93c82 to
33cc505
Compare
|
@tjmehta See apollographql/graphql-subscriptions#232 I think we should push for removing iterall and using native types. |
|
agreed |
|
#549 I've done this, hope it will be merged... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated asyncIterator's type to include Iterable so that it can be used with
for...of. Unfortunately iterall's $$asyncIterator doesn't play nice with typescript, so I had to add some ts-ignores.