Fix wrong coverage around antimeridian #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Cool, thanks. I'll have a look now. |
davidmoten
approved these changes
Sep 5, 2021
Owner
davidmoten
left a comment
davidmoten
left a comment
There was a problem hiding this comment.
Looks great, thanks! I'll merge now, upgrade a few libraries then release probably in a matter of hours. thanks for the contribution.
Owner
|
a bit of work to updating plugins etc but i'll release within the next day or so |
Owner
|
0.8 on Maven Central now |
Contributor
Author
|
Great, thank you very much for this super fast review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use
GeoHash.coverBoundingBoxmethod with a bounding box around antimeridian (180/-180) because it does not allow bottomRightLon to be lower than topLeftLon (Google Maps behavior) or it does not handle correctly longitude outside [-180, 180] range (Leaflet behavior).This pull request addresses this use case and also fixes issues in #25 and #34.
Now the
GeoHash.coverBoundingBoxLongsmethod allow more longitudes values in input. For instance, these values are accepted (see unit tests):